Look for quicklisp in /var/lib or /home directory#32
Open
Valenoern wants to merge 1 commit intohellerve:masterfrom
Open
Look for quicklisp in /var/lib or /home directory#32Valenoern wants to merge 1 commit intohellerve:masterfrom
Valenoern wants to merge 1 commit intohellerve:masterfrom
Conversation
vindarel
reviewed
May 8, 2023
| ;; check for the two most likely places quicklisp is installed and try to load it | ||
| ;; on v-refracta, it is simply installed in /var/lib/ | ||
| (let ((home-quicklisp (merge-pathnames "quicklisp/setup.lisp" (user-homedir-pathname))) | ||
| (var-quicklisp (merge-pathnames "setup.lisp" #p"/var/lib/quicklisp/"))) |
Contributor
There was a problem hiding this comment.
Hey, this var-quicklisp is inside the let, it is badly indented here.
vindarel
reviewed
May 8, 2023
| (load "~/quicklisp/setup") | ||
|
|
||
| ;; check for the two most likely places quicklisp is installed and try to load it | ||
| ;; on v-refracta, it is simply installed in /var/lib/ |
Contributor
There was a problem hiding this comment.
Mentioning v-refracta might be a private comment not needed here?
My 2c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a Linux distribution called v-refracta, and on it most of the programs are supposed to be Lisp.
Here I've patched sbcli to look in either the home directory or a "standard" directory for quicklisp installed by a distribution package.
I'm open to putting quicklisp in a different directory than
/var/lib/quicklisp, and if you can think of a better one you could change it here. (I assumed it needed to go in /var because it was going to be written to in less predictable ways than is expected with/usr/share.)